[FFmpeg-devel] MPEG-2 Acceleration Refactor
Sun Jun 17 03:52:19 CEST 2007
On Sat, Jun 16, 2007 at 06:44:21PM -0700, Greg Hulands wrote:
> Based on the START/STOP_TIMER stuff showing the patch is actually
> faster I have tidied the patch a little more and removed the function
> prototypes to the _fast functions at the top of the file.
> If there are any other problems from stopping this getting committed,
> please let me know.
yes, why is it faster now and was slower before?
> Index: mpeg12.c
> --- mpeg12.c (revision 9339)
> +++ mpeg12.c (working copy)
> @@ -47,25 +47,25 @@
> #ifdef CONFIG_ENCODERS
> static void mpeg1_encode_block(MpegEncContext *s,
> - DCTELEM *block,
> - int component);
> + DCTELEM *block,
> + int component);
note a single cosmetic (whitespace only) change in a patch which contains
functional changes leads to rejection of the patch
such changes belong into a seperate patch
remainder of the patch not reviewed as its full of cosmetics
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
More information about the ffmpeg-devel