[FFmpeg-devel] [PATCH] h264 luma interpolation 8x8 for altivec

[Michael Niedermayer]

Hi

On Mon, Jun 18, 2007 at 07:32:20PM +0200, Luca Barbato wrote:
[...]
> > Additionally I'm working on Altivec functions for doing the luma
> > interpolation for non-square blocks: 16x8, 8x16,  8x4 and 4x8. The
> > implementation of the functions is very easy. My question is how to
> > integrate them with DSPContext structure. An option could be to add a
> > position to the XXX_pixels_tab[][] structure, like this
> > index | size
> > 0: 16x16
> > 1: 8x8
> > 2: 4x4
> > 3: 16x8
> > 4: 8x16
> > 5: 8x4
> > 6: 4x8
> 
> I'd like to know the opinion of the other people involved (x86 hackers
> I'm speacking to you ^^)

i do not think that these rectangular functions will speed the code up
so we need benchmarks showing that iam wrong first ...
these benchmarks MUST be done over the whole h264 decoder not just the
MC code as the code will likely get slower due to code size / code cache
issues

[...]
> first, the patch is about 700 lines, a bit big, so I'll be slow
> commenting, maybe you should try to split it in pieces.

seconded, always split patches when possible, it makes everyones life
easier and very significantly speeds up review

[...]

> >-  if ( (unsigned long) dst & 0x0f) {
> ...
> >+  if (((unsigned long)dst) % 16 == 0) {
> 
> hm..

% and excessive ()

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you really think that XML is the answer, then you definitly missunderstood
the question -- Attila Kinali
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070618/c4cee1b8/attachment.pgp>