[FFmpeg-devel] dv_read_seek over 2GB fix

Maksym Veremeyenko verem
Tue Jun 19 14:08:30 CEST 2007


Roman Shaposhnick ?????:

> On Tue, 2007-06-19 at 02:33 +0200, Michael Niedermayer wrote:
>> Hi
>>
>> On Mon, Jun 18, 2007 at 07:03:41PM +0300, Maksym Veremeyenko wrote:
>>> Michael Niedermayer ?????:
>>>
>>>> offset_t url_fseek(ByteIOContext *s, offset_t offset, int whence)
>>>> {
>>>> [...]
>>>>        return AVERROR(EINVAL);
>>>> [...]
>>>>        offset_t res = AVERROR(EPIPE);
>>>>
>>>>
>>>>> this value re-returned to av_seek_frame that 
>>>>> do not care about error code - it's interesting only in sign of returned 
>>>>> value from:
>>>> its not relevant if any current code checks for specific errors or just
>>>> error vs. no error, the code should properly pass error codes
>>> this version of attached patch returns 0 on success or negative error code.

>> looks ok (minus the trailing whitespace) but iam not dv maintainer,
>> roman is that ...
Trailing spaces removed. cleaned patch version attached.

>   Isn't the bigger issue here that AVInputFormat::read_seek() has a
> return type that doesn't make much sense with the lfcompile(5) ?
problem is in "truncating" returned value...

Is this patch OK? Could you commit this one?


-- 
________________________________________
Maksym Veremeyenko
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dv_read_seek_over_2gb_fix3.patch
Type: text/x-patch
Size: 431 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070619/13c7fdfc/attachment.bin>



More information about the ffmpeg-devel mailing list