[FFmpeg-devel] [PATCH] move fast dct and trellis quantize function pointers initialization

Michael Niedermayer michaelni
Wed Jun 20 09:56:59 CEST 2007


On Wed, Jun 20, 2007 at 08:38:06AM +0100, M?ns Rullg?rd wrote:
> Benoit Fouet <benoit.fouet at purplelabs.com> writes:
> > Hi,
> >
> > the patch moves the encoder specific part of DCT_common_init under the
> > same ifdef.
> > it also removes the comment telling to do so :)
> OK with me.

approving pacthes for code maintained by others? didnt you just complain
about me approving one for configure?

anyway i dont mind it if you do, actually iam happy if people help 
reviewing and approving stuff but here the patch is not ok at all

s->fast_dct_quantize= s->dct_quantize;
is currently done after dct_quantize is set up (possibly to a mmx optimized
variant) but after the patch its just set to the c variant ...


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you really think that XML is the answer, then you definitly missunderstood
the question -- Attila Kinali
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070620/79e482da/attachment.pgp>

More information about the ffmpeg-devel mailing list