[FFmpeg-devel] [PATCH] h264: rbsp de-escape and data partitioning..

Reimar Doeffinger Reimar.Doeffinger
Wed Jun 20 12:12:16 CEST 2007


Hello,
On Wed, Jun 20, 2007 at 11:58:30AM +0200, Thorsten Jordan wrote:
> M?ns Rullg?rd schrieb:
> > Andreas ?man wrote:
> >>> i think the "? 1 : 0" is not needed
> >> They are not indeed, but i tend to keep such things in for
> >> clarity
> > I keep them out for clarity.  If you don't think it's clear without them,
> > go back and read your K&R once more.
> hey, no reason to be rough, i agree with Andreas.
> Here a boolean value is mixed with integer (index).
> It is indeed more cleare to write the "? 1 : 0" thing.
> This may be ok for C but its not really "human readable" on first glance.
> The compiler can optimize it anyway.

I disagree, for those who really know C the variant without ?: is vastly
more readable.
It should also be quite natural to the mathematically-inclined.

Greetings,
Reimar Doeffinger




More information about the ffmpeg-devel mailing list