[FFmpeg-devel] [PATCH] intreadwrite.h needs bswap.h

Måns Rullgård mans
Sun Jun 24 16:24:14 CEST 2007


Reimar D?ffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> writes:

> Hello,
> if HAVE_FAST_UNALIGNED is defined, libavutil/intreadwrite.h needs the
> bswap stuff, so IMO it should include bswap.h.
> Would attached patch be acceptable?
>
> Index: libavutil/intreadwrite.h
> ===================================================================
> --- libavutil/intreadwrite.h	(revision 9413)
> +++ libavutil/intreadwrite.h	(working copy)
> @@ -20,6 +20,7 @@
>  #define INTREADWRITE_H
>
>  #include <stdint.h>
> +#include "bswap.h"
>
>  #ifdef __GNUC__

If a file needs something from a header, it should #include it, so
patch is OK.

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-devel mailing list