[FFmpeg-devel] [PATCH] Remove localtime_r from os_support

Ramiro Ribeiro Polla ramiro
Mon Jun 25 18:21:24 CEST 2007

M?ns Rullg?rd wrote:
> Ramiro Ribeiro Polla <ramiro at lisha.ufsc.br> writes:
>> Hello,
>> It seems FFmpeg checks for it in configure, provides an implementation
>> if it doesn't exist, but this function isn't used anywhere.
>> grep for localtime_r shows:
>> configure:    localtime_r
>> configure:check_func localtime_r
>> libavformat/os_support.c:struct tm *localtime_r(const time_t *t,
>> struct tm *tp)
>> It seems it was added in 2003 for MinGW, but I couldn't find the exact
>> revision. Was it used a long time ago? Is it safe to remove this now?
> It's been in there much longer than that, for what reason I cannot
> tell.  The last use of it was apparently (thanks git) removed in
> 2004.

Since you did the search and found the revision, could you tell us which 
one it was?

> By all means apply the patch.


Ramiro Polla

More information about the ffmpeg-devel mailing list