[FFmpeg-devel] [PATCH] play aiff without common tag

[Michael Niedermayer]

Hi

On Mon, Jun 25, 2007 at 06:54:15PM +0100, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> 
> > Hi
> >
> > On Mon, Jun 25, 2007 at 07:21:20PM +0200, Michael Niedermayer wrote:
> >> Hi
> >> 
> >> On Mon, Jun 25, 2007 at 05:51:59PM +0200, Reimar D?ffinger wrote:
> >> > Hello,
> >> > attached patch fixes
> >> > http://samples.mplayerhq.hu/AIFF/invalid_nocommon.aiff.
> >> > While according to the specification says this file invalid I think it
> >> > is preferable to support it anyway, esp. because leaving values
> >> > uninitialized and even causing a division by zero is really bad anyway
> >> > (and it even leaves e.g. MPlayer thinking this is a video file...).
> >> 
> >> looks ok
> >
> > hmm ive just noticed baptiste is maintainer of aiff ...
> > so its his decission
> >
> > but id like to repeat that ffmpeg CANNOT reject files just because they
> > are not conforming to specs, we would be rejecting >50% of all files
> > otherwise and ffmpeg would be unuseable
> 
> For uncommon types of nonconformance we should fail with an error
> unless -strict -1 was specified.

i think this may have some unintended side effect
that is some users will make strict -1 default somehow and then also
use it for encoding unintentionally which will create more non standard
files ...

that said, i am fine with whatever solution people want, as long as
ffmpeg does not reject files just because they are broken with no way
to override

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070625/3c2cf149/attachment.pgp>