[FFmpeg-devel] [PATCH] RoQ Cosmetics - 1

Vitor vitor1001
Wed Jun 27 02:23:26 CEST 2007


Hi

Michael Niedermayer wrote:
> Hi
> 
> On Tue, Jun 26, 2007 at 07:41:13PM +0200, Vitor wrote:
>> Hi
>>
>> This patch replaces RoqContext.y_stride/RoqContext.c_stride by 
>> RoqContext.stride, since it uses the 4:4:4 color space (I have the 
>> impression that it is pretty standard in FFmpeg to suppose that data not 
>> subsampled have the same stride).
> 
> iam against this change, while its true that the stride will very very likely
> be the same and the code maybe would fail even without this patch if they
> differ, its IMHO simply not correct
> 
> [...]
> 

Without this assumption, the decoder is broken. The attached patch 
should fix it. I'll have a look also in the encoder.

-Vitor
-------------- next part --------------
A non-text attachment was scrubbed...
Name: stride.diff
Type: text/x-patch
Size: 1553 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070627/bd8e5432/attachment.bin>



More information about the ffmpeg-devel mailing list