[FFmpeg-devel] [PATCH] RoQ Cosmetics - 1

[Michael Niedermayer]

Hi

On Wed, Jun 27, 2007 at 02:23:26AM +0200, Vitor wrote:
> Hi
> 
> Michael Niedermayer wrote:
> >Hi
> >
> >On Tue, Jun 26, 2007 at 07:41:13PM +0200, Vitor wrote:
> >>Hi
> >>
> >>This patch replaces RoqContext.y_stride/RoqContext.c_stride by 
> >>RoqContext.stride, since it uses the 4:4:4 color space (I have the 
> >>impression that it is pretty standard in FFmpeg to suppose that data not 
> >>subsampled have the same stride).
> >
> >iam against this change, while its true that the stride will very very 
> >likely
> >be the same and the code maybe would fail even without this patch if they
> >differ, its IMHO simply not correct
> >
> >[...]
> >
> 
> Without this assumption, the decoder is broken. The attached patch 
> should fix it. I'll have a look also in the encoder.
[...]
> @@ -109,10 +112,13 @@
>          return;
>      }
>  
> -    for(cp = 0; cp < 3; cp++)
> -        block_copy(ri->current_frame->data[cp] + (y * ri->y_stride) + x,
> -                   ri->last_frame->data[cp] + (my * ri->y_stride) + mx,
> -                   ri->y_stride, ri->y_stride, sz);
> +    for(cp = 0; cp < 3; cp++) {
> +        stride = cp==0 ? ri->y_stride : ri->c_stride;

ri->current_frame.linesize[cp] seems like the more natural solution


> +        block_copy(ri->current_frame->data[cp] + (y*stride) + x,
> +                   ri->last_frame->data[cp] + (my*stride) + mx,

superfluos () but removing that belongs to a seperate change theoretically

and iam in favor of giving you a svn write account
if there are no objections and you agree to our svn/development policy
then send diego a username&password

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070627/73ce3edb/attachment.pgp>