[FFmpeg-devel] [PATCH] updated LGPL AC-3 decoder

[Justin Ruggles]

Michael Niedermayer wrote:
> Hi
> 
> On Thu, Jun 21, 2007 at 10:47:43AM +0200, Diego Biurrun wrote:
>> On Tue, Jun 19, 2007 at 06:38:19PM +0200, Michael Niedermayer wrote:
>>> On Tue, Jun 19, 2007 at 09:22:22AM +0200, Diego Biurrun wrote:
>>>> On Tue, Jun 19, 2007 at 09:09:57AM +0200, Benjamin Larsson wrote:
>>>>> Diego Biurrun skrev:
>>>>>> On Sat, Jun 16, 2007 at 02:11:46PM +0200, Michael Niedermayer wrote:
>>>>>>   
>>>>>>> [...]
>>>>>>>  do you still have the script? you used to checkin the vorbis code?
>>>>>> Where exactly is the problem with checking in the revisions from the soc
>>>>>> repository?
>>>>> The patch does not only contain what's in the repo.
>>>> So where exactly is the problem?
>>> _AFAIK_
>>> we have no script which is capable to atomatically and nicely check in
>>> all the revisions from soc and the later changes outside soc with nice
>>> commit messages which refer to the original author, repo, data and rev.
>>>
>>> and noone volunteered to spend an hour doing it manually ...
>>>
>>> it also maybe could be done with git-svn but here again noone who has
>>> that setup with ffmpeg svn has so far volunteered to do the work
>>>
>>> and neither did anyone dare to check it in without history ...
>> Would a test repo be helpful?  That's easy enough to create ...
> 
> justin?
> 
> and anyway there seem to be just ~22 revissions of ac3 in soc this is
> a mere 10min manual work to checkout + copy & paste author and date &
> checkin by hand

ok. sorry for my delayed response. does this sound okay?

1) modify the SoC repository first to move code from ac3_decoder.h into 
ac3_decoder.c

2) add ac3_decoder.c to FFmpeg SVN as initial version from SoC

3) commit each change from SoC noting author and date

4) make incremental changes to ac3_decoder.c to make it current to the 
latest patch

5) "activate" the decoder by making the necessary changes to 
avcodec.h/allcodecs.h/Makefile/Changelog/etc...