[FFmpeg-devel] [PATCH] Mention unneeded casts and parenthesis in Coding Rules (doc)

Benoit Fouet benoit.fouet
Wed Jun 27 12:38:18 CEST 2007


Michael Niedermayer wrote:
> Hi
>
> On Wed, Jun 27, 2007 at 11:49:46AM +0200, Vitor wrote:
>   
>> M?ns Rullg?rd wrote:
>>     
>>>>> +Ideally, casts should be used only when necessary. Unneeded parenthesis
>>>>> +should also be avoided if they don't make the code easier to understand.
>>>>> +
>>>>>  
>>>>>           
>>>> i think plural is parentheses
>>>>         
>>> It is.  I'd also drop the "ideally".  An unnecessary cast is a bug.
>>> Actually, a necessary cast is also often a bug.
>>>
>>>       
>> Changed both.
>>     
>
> looks ok
>
> [...]
>   
>   

Applied

Ben
-- 
Purple Labs S.A.
www.purplelabs.com




More information about the ffmpeg-devel mailing list