[FFmpeg-devel] [PATCH]pes packetizer

[Baptiste Coudurier]

M?ns Rullg?rd wrote:
> Baptiste Coudurier wrote:
>> Hi
>>
>> M?ns Rullg?rd wrote:
>>> Baptiste Coudurier wrote:
>>>>> +typedef struct {
>>>>> +    int is_ps;  /*< whether it is a Program Stream */
>>>>> +    int packet_number;
>>>>> +} PESContext;
>>>> We might have 3 possibilites (PS, TS, PES).
>>>> An enum is better IMHO.
>>> Why does it matter what the destination is?  The PES syntax is the
>>> same in all cases.  The only exception is the unspecified size
>>> video packets that are allowed in TS.
>>>
>> P-STD buffer flag, P-STD buffer size, which are only needed for Program
>> Stream, current code writes it atm.
> 
> They are still allowed for transport streams.  A better approach would be
> to pass a set of flags selecting which optional features to use.
> 

I would say not forbidden, yes, values are then not applicable in TS.

Im not against a set of flags if it simplifies things of course.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312