[Ffmpeg-devel] Prefix for img_* functions

[Michael Niedermayer]

Hi

On Thu, Mar 01, 2007 at 05:50:23PM +0100, Baptiste Coudurier wrote:
> Hi
> 
> Panagiotis Issaris wrote:
> > Hi,
> > 
> > Michael Niedermayer schreef:
> >> Hi
> > 
> >> On Thu, Mar 01, 2007 at 05:16:43PM +0100, Panagiotis Issaris wrote:
> >>> -----BEGIN PGP SIGNED MESSAGE-----
> >>> Hash: SHA1
> >>>
> >>> Hi,
> >>>
> >>> Michael Niedermayer schreef:
> >>>> Hi
> >>>>
> >>>> On Mon, Feb 26, 2007 at 03:27:10AM +0100, Panagiotis Issaris wrote:
> >>>>> Hi,
> >>>>>
> >>>>> Shouldn't the img_crop, img_copy and img_pad functions get av_ prefixes?
> >>>> yes but the old should stay available under #if version something and
> >>>> with deprecated attribute
> >>> How would you prefer having the old versions available? Using #define's,
> >>> duplicate code or the old functions calling the new ones? Or some other way?
> >> #defines seem best after 5sec of thoughts
> > 
> > The attached patch adds the prefixes to img_crop, img_copy and img_pad.

patch looks ok


[...]

> While we are at it, why not av_picture_pad/copy/crop ? Those funcs take
> AVPicture as arg.

that would be fine too, pick whichever you guys like best ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070302/bf96291a/attachment.pgp>