[Ffmpeg-devel] [PATCH] fix ffmpeg crash when thread_count is zero

Michael Niedermayer michaelni
Fri Mar 2 13:38:10 CET 2007


Hi

On Fri, Mar 02, 2007 at 12:02:01PM +0800, Limin Wang wrote:
> Hi,
> 
> Last patch is bug, please review the new patch, it has pass
> "make test". 

> Or we check the thread_count and never permit
> it zero.

yes thread_count=0 is invalid, AVOption in libavcodec/utils.c should have a
min of 1 for thread_count and that AVOption array should be used to parse
thread_count instead of the duplicated code in ffmpeg.c only thing needed
for that is to remove the thread_count parsing code from ffmpeg.c and
move the "no threads support" warning to some other place

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070302/f978c325/attachment.pgp>



More information about the ffmpeg-devel mailing list