[Ffmpeg-devel] [PATCH] flv adpcm encoder

[Baptiste Coudurier]

Hi

Benjamin Larsson wrote:
> Jeff Clagg wrote:
>> On Sun, Mar 04, 2007 at 10:51:50PM +0100, Benjamin Larsson wrote:
>>> Hi, this is an almost working by the specs adpcm encoder for flv and swf
>>> files. I think the reason it isn't work so well is because of the muxing
>>> and not the encoding. If the muxing isn't fixed there is not much reason
>>> for this patch to be applied.
>> I'm very impressed by how small and elegant the code is.
> 
> Thanks.
> 
> Anyway, here is an updated less elegant version.
> 

> +        }
> +
> +        for (i=0 ; i<4096 ; i++) {

Is there a way to take enc->frame_size into account ? It would be much
simpler to mux adpcm in flv/swf, and require enc->frame_size to be set,
or compute it:

frame_size = (sample_rate*video_rate.num ) / video_rate.den;

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312