[Ffmpeg-devel] [PATCH 12/31] Move rtp_parse_open() to the header file.

[Michael Niedermayer]

Hi

On Mon, Mar 12, 2007 at 04:21:33PM +0100, Panagiotis Issaris wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hi,
> 
> takis.issaris at uhasselt.be schreef:
> > Move libavutil/rtp.c public API comments to rtp.h. The moved comments are
> > unmodified.
> > 
> > Signed-off-by: Panagiotis Issaris <takis.issaris at uhasselt.be>
> > ---
> >  libavformat/rtp.c |    6 ------
> >  libavformat/rtp.h |    7 +++++++
> >  2 files changed, 7 insertions(+), 6 deletions(-)
> Ping... :-)
> 
> All other patches from the [xx/31] patchset have been reviewed and
> applied, the only exceptions which received no comments were the ones
> listed here:
> [12/31] Move rtp_parse_open() to the header file.
> [13/31] Move rtp_parse_packet() to the header file.
> [14/31] Move rtp_set_remote_url() to the header file.
> [15/31] Move rtp_get_local_port() to the header file.
> [16/31] Move rtp_get_file_handles() to the header file.
> 
> The descriptions are incorrect as the function itself isn't moved, but
> the Doxygen comments only.

they move comments to rtp.h yes, that on its own would be all fine but
rtp.h is a installed header and these functions dont look like they
should be in a installed header

maybe rtp.h should not be installed at all i dunno

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070314/9b6e300a/attachment.pgp>