[Ffmpeg-devel] Fixed point arithmetic RealAudio G2 (cook) decoder

Ian Braithwaite ian
Wed Mar 14 08:24:43 CET 2007


Vadim Lebedev wrote:
>
> Ian Braithwaite wrote:
...
> Ian,   i think the in the following code 'int category'  should be 'int
> *category' ....
>
>> /**
>>- * Unpack the subband_coef_index and subband_coef_noise vectors.
>>+ * Unpack the subband_coef_index and subband_coef_sign vectors.
>>  *
>>  * @param q                     pointer to the COOKContext
>>  * @param category              pointer to the category array
>>  * @param subband_coef_index    array of indexes to quant_centroid_tab
>>- * @param subband_coef_noise    use random noise instead of predetermined
>> value
>>+ * @param subband_coef_sign     signs of coefficients
>>  */
>>
>> static int unpack_SQVH(COOKContext *q, int category, int* subband_coef_index,
>>-                       int* subband_coef_noise) {
>>+                       int* subband_coef_sign) {

You're right that the doc. and code don't agree, in this case it's
the doc that's wrong.

 * @param category              the category of this subband

would be better.


Regards,
Ian






More information about the ffmpeg-devel mailing list