[PATCH] iWMMXt support was Re: [Ffmpeg-devel] iWMMXt support

[Måns Rullgård]

Tim Chick <chick at computergeek.freeserve.co.uk> writes:

> On Wednesday 14 March 2007 18:47, M?ns Rullg?rd wrote:
>> Tim Chick <chick at computergeek.freeserve.co.uk> writes:
>> > Hi List,
>> >
>> > In libavcodec/armv4l/dsputil_iwmmxt.c
>> >
>> > The function:
>> >
>> > int mm_support(void)
>> > {
>> >     return 0; /* TODO, implement proper detection */
>> > }
>> >
>> > Only ever returns 0. This means the iwmmxt code never gets installed.
>> If it can't be easily detected at runtime, set it at compile time like
>> the other ARM features.
>
> OK, please consider the patch attached.
>
> Thanks,
> Tim
>
> Index: libavcodec/armv4l/dsputil_iwmmxt.c
> ===================================================================
> --- libavcodec/armv4l/dsputil_iwmmxt.c	(revision 8407)
> +++ libavcodec/armv4l/dsputil_iwmmxt.c	(working copy)
> @@ -132,7 +132,10 @@
>  
>  int mm_support(void)
>  {
> -    return 0; /* TODO, implement proper detection */
> +    /* A run time test is not simple. If this file is compiled in
> +     * then we should install the functions
> +     */
> +    return MM_IWMMXT; /* TODO, implement proper detection */
>  }

Why not get rid of that function completely?

-- 
M?ns Rullg?rd
mans at mansr.com