[Ffmpeg-devel] [PATCH] Theora in MKV (GSoC '07 Qualification)

Aurelien Jacobs aurel
Sun Mar 25 03:21:26 CEST 2007


On Thu, 22 Mar 2007 22:04:00 -0400
David Conrad <umovimus at gmail.com> wrote:

> On Mar 22, 2007, at 9:56 PM, David Conrad wrote:
> 
> > On Mar 22, 2007, at 8:43 PM, Michael Niedermayer wrote:
> >
> >> Hi
> >>
> >> On Thu, Mar 22, 2007 at 08:23:08PM -0400, David Conrad wrote:
> >>> Hi,
> >>>
> >>> Attached is a patch that allows the Theora decoder to accept the
> >>> extradata format used in Matroska. This matches the behaviour of the
> >>> Vorbis decoder (in fact, I wound up copying the setup from the  
> >>> Vorbis
> >>> decoder; the only difference is the length of the first header.) I
> >>
> >> as the code is identical to vorbis, it should not be duplicated but
> >> rather shared. putting the code into a common file xiph.c xiph.h  
> >> maybe?
> >> would be better
> >
> > Something like the attached?
> 
> Trailing whitespace removed (forgot to check before sending...)

Commited in 3 steps with some minor adjustments.

Aurel




More information about the ffmpeg-devel mailing list