[Ffmpeg-devel] Fix missing declaration for Altivec

Michael Niedermayer michaelni
Fri Mar 30 16:21:33 CEST 2007


Hi

On Fri, Mar 30, 2007 at 04:13:02PM +0200, Stanislav Brabec wrote:
> M?ns Rullg?rd wrote:
> > Stanislav Brabec said:
> > > Hallo.
> > >
> > > Attached patch fixes missing declaration if HAVE_ALTIVEC is true.
> 
> > Firmly rejected.  Prototypes for extern functions belong in a header file
> > included by the file with the function definition and every file that uses
> > the function.  Anything else is asking for trouble.
> 
> Well, than it should be put into swscale_internal.h or so. Otherwise
> compiler uses incompatible implicit all-args-int declaration.
> 
> What about this nicer patch:

what is the #ifdef good for?

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070330/a2f6ec3f/attachment.pgp>



More information about the ffmpeg-devel mailing list