[FFmpeg-devel] PATCH libswscale yuv2rgbtst infastructure

Marc Hoffman mmh
Tue May 1 14:53:59 CEST 2007


Diego Biurrun writes:
 > On Tue, May 01, 2007 at 06:31:32AM -0400, Marc Hoffman wrote:
 > > 
 > > yuv to rgb color space converter test, debug and performance
 > > infastructure.
 > > 
 > > --- libswscale/yuv2rgbtst.c	(revision 0)
 > > +++ libswscale/yuv2rgbtst.c	(revision 0)
 > 
 > Please use a less cryptic name, vowels are cheap these days.
 > yuv2rgb_test.c maybe?
 > 
 > > +#if defined(__MINGW32__) || defined(CONFIG_OS2)
 > > +static int64_t getutime(void)
 > 
 > CONFIG_OS2 ?
 > 

I copied the code directly from ffmpeg.c and left it untouched.

I will change the name, with the next review cycle. I actually like
the underscore _test better too.






More information about the ffmpeg-devel mailing list