[FFmpeg-devel] [PATCH] initialize variables in utils.c

Michael Niedermayer michaelni
Wed May 2 12:31:36 CEST 2007


Hi

On Wed, May 02, 2007 at 12:03:44PM +0200, Benoit Fouet wrote:
> Michael Niedermayer wrote:
> > Hi
> >
> > On Wed, May 02, 2007 at 11:33:29AM +0200, Benoit Fouet wrote:
> >   
> >> Hi,
> >>
> >> even if the call to av_gen_search is safe, those two variables can be
> >> used uninitialized
> >>     
> >
> > hmm, as long as this doesnt cause a real bug iam against initalizing them
> > initalizing them makes it look as if they might be read and used
> >
> > [...]
> >   
> >   
> well, in the function in which they are defined, this is the case
> it's only because we know that the call to av_gen_search will not read
> them because of the value of ts_min/max

and in how far are max=min=0 better than random values?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct awnser.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070502/742c1f8f/attachment.pgp>



More information about the ffmpeg-devel mailing list