[FFmpeg-devel] [PATCH] add dca and vc1 objects to Makefile when parsers are enabled

Michael Niedermayer michaelni
Thu May 3 12:07:56 CEST 2007


On Thu, May 03, 2007 at 11:54:56AM +0200, Diego Biurrun wrote:
> On Thu, May 03, 2007 at 09:28:57AM +0200, Benoit Fouet wrote:
> > 
> > seen on ffmpeg user mailing list
> > when disabling en/decoders, those two objects are not built even though
> > they are needed to parse
> The patch is OK, but I think it would be better to put the dca and vc1
> parser code in parser.c along with the rest of the parsers.  The parser
> code is a very small part of both decoders.

_all_ parsers should be put in seperate files. putting them in parser.c
is an extreemly ugly hack and while i agreed for ac3 as noone was willing
to solve that properly i will NOT agree to move the other parsers to the
wrong file too!

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070503/153dd4f2/attachment.pgp>

More information about the ffmpeg-devel mailing list