[FFmpeg-devel] [PATCH] Fix Vorbis encoder Xiph dependency

[Panagiotis Issaris]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Diego,

Diego Biurrun wrote:
> On Thu, May 10, 2007 at 04:18:28PM +0200, Panagiotis Issaris wrote:
>> When configuring ffmpeg with all decoders disabled, a problem occurs:
>> ./configure --disable-decoders
>> ...
>> gcc -L"/usr/local/src/ffmpeg"/libavformat
>> - -L"/usr/local/src/ffmpeg"/libavcodec -L"/usr/local/src/ffmpeg"/libavutil
>> - -Wl,--warn-common  -rdynamic -export-dynamic -Wl,--as-needed
>> - -Wl,-rpath-link,"/usr/local/src/ffmpeg"/libavcodec
>> - -Wl,-rpath-link,"/usr/local/src/ffmpeg"/libavformat
>> - -Wl,-rpath-link,"/usr/local/src/ffmpeg"/libavutil -g -o ffmpeg_g
>> ffmpeg.o cmdutils.o -lavformat -lavcodec -lavutil -lm -lz -ldl
>> /usr/local/src/ffmpeg/libavcodec/libavcodec.a(vorbis.o): In function `vorbis_decode_init':
>> /usr/local/src/ffmpeg/libavcodec/vorbis.c:1061: undefined reference to `ff_split_xiph_headers'
>> collect2: ld returned 1 exit status
>> make: *** [ffmpeg_g] Error 1
>>
>> The attached patch fixes this by making sure the Vorbis' encoders
>> references to ff_split_xiph_headers() are there.
>>
>> --- libavcodec/Makefile	(revision 8977)
>> +++ libavcodec/Makefile	(working copy)
>> @@ -171,7 +171,7 @@
>>  OBJS-$(CONFIG_VORBIS_DECODER)          += vorbis.o vorbis_data.o xiph.o
>> -OBJS-$(CONFIG_VORBIS_ENCODER)          += vorbis_enc.o vorbis.o vorbis_data.o
>> +OBJS-$(CONFIG_VORBIS_ENCODER)          += vorbis_enc.o vorbis.o vorbis_data.o xiph.o
> 
> Looks OK, commit.
Done.

With friendly regards,
Takis
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGQy5y9kOxLuzz4CkRAvdSAJ0WXJBSKfQMNs18+nXtKtGvlqytzgCfTrsA
Z3jHcW+YwGJ5bjRQsMCWT4g=
=xuyd
-----END PGP SIGNATURE-----