[FFmpeg-devel] [PATCH] make libavcodec use bytestream functions

Måns Rullgård mans
Thu May 10 17:27:34 CEST 2007


Ramiro Ribeiro Polla wrote:

> Do you prefer this patch?

No, that's not even standard C.  The first patch, the one with the
do { ... } while(0) is good and should be applied.

> It looked uglier to me, so that's why I preferred fixing pcm.c.
> But with your explanation, it sounds saner.
>
> After intreadwrite.h gets fixed, should I revert the temporary fix I
> made on pcm.c (which wasn't the best solution)?

Yes, please.  I don't like the way it looks now.

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-devel mailing list