[FFmpeg-devel] [PATCH] remove __attribute__((unused))

[Michael Niedermayer]

Hi

On Sun, May 13, 2007 at 06:51:01PM +0200, Reimar D?ffinger wrote:
[...]
> > > Index: libavcodec/h264.c
> > > ===================================================================
> > > --- libavcodec/h264.c	(revision 9014)
> > > +++ libavcodec/h264.c	(working copy)
> > > @@ -1800,7 +1800,7 @@
> > >      const int lt= src[-1-1*stride];
> > >      LOAD_TOP_EDGE
> > >      LOAD_LEFT_EDGE
> > > -    const __attribute__((unused)) int unu= l3;
> > > +    const int unu= l3;
> > 
> > This and similar cases is to kill a warning about l3 (or whatever)
> > being unused.  The variable l3 is declared by the macro
> > LOAD_LEFT_EDGE, but isn't used everywhere this macro is invoked.  I
> > think the proper solution is to put attribute_unused on all the
> > variables declared by those macros.
> 
> I tend to agree but this is for the maintainers to decide.

iam ok with it ...

iam also ok with the patch

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070513/92b1365a/attachment.pgp>