[FFmpeg-devel] cleanup mjpeg encoding

Aurelien Jacobs aurel
Mon May 14 02:11:17 CEST 2007


On Mon, 14 May 2007 02:02:26 +0200
Michael Niedermayer <michaelni at gmx.at> wrote:

> Hi
> 
> On Mon, May 14, 2007 at 02:01:06AM +0200, Aurelien Jacobs wrote:
> > Hi,
> > 
> > The mjpeg_write_tables and mjpeg_data_only_frames vars are always set
> > to the same value.
> > Is the attached patch ok ?
> 
> no, because it will break LJPEG and JPEG-LS,

JPEG-LS encoder don't even need mjpeg.c to be compiled so it for sure
won't be affected. LJPEG call MPV_encode_init() just the same way as
MJPEG, and that's this function which set the constant value for those
2 variables. So LJPEG shouldn't be affected either.

> did you run the regression tests?

Yes. No regression.

Aurel




More information about the ffmpeg-devel mailing list