[FFmpeg-devel] [PATCH] Use DECLARE_ALIGNED_16 in libavcodec/ppc/

Diego Biurrun diego
Thu May 17 10:36:42 CEST 2007


On Thu, May 17, 2007 at 10:26:55AM +0200, Reimar D?ffinger wrote:
> Hello,
> On Thu, May 17, 2007 at 12:30:10AM +0200, Guillaume POIRIER wrote:
> >  Attached patch does $SUBJ. I'll apply it over the week-end unless I
> >  hear strong objections.
> > 
> >  I'll have to test it first, since this patch has been prepared on a
> >  x86 machine :-)
> 
> Are there any comments on whether to put the const inside the macro or
> before it? I'd prefer if this was done consistently.
> Currently we only support __declspec in addition, can someone say which
> of these are valid:
> __declspec(align(16)) static const int test;
> static const __declspec(align(16)) int test;

IIRC gcc issues a warning with -Wextra if static is not the leftmost keyword.

Diego




More information about the ffmpeg-devel mailing list