[FFmpeg-devel] flashsvenc.c - sampling block size too low

[Alex Beregszaszi]

Hi,

@@ -74,6 +82,10 @@ typedef struct FlashSVContext {
     int block_size;
     z_stream zstream;
     int last_key_frame;
+    int* tpSizes;

What does tp means? Please use tp_sizes.


+        char* ptrnext = avctx->stats_in;

Why do you need to maintain p or ptr? char *next is enough.

+    int blockSize = 6;
+    int res;
+
+    int comBnd = compressBound(block_height * block_width * 3);
+    uint8_t *buf = av_mallocz(comBnd);
+
...
+            int smallW, smallH;
+            smallW = 0;
+            smallH = 0;
+            int sizeIndex = 0;
+            unsigned int smallest = s->tpSizes[0];

Again, we dislike mixed case variables.

+    }
+
+
+    int w, h;
+
+    //if first pass on a two pass, at each i-frame, record best block
size for past i-frame set

Move variable declaration.

Thanks.

--
Alex Beregszaszi