[FFmpeg-devel] [PATCH] Compilation broken failing on Sonic LS

[Panagiotis Issaris]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

Aurelien Jacobs wrote:
> On Mon, 21 May 2007 16:04:24 +0200
> Aurelien Jacobs <aurel at gnuage.org> wrote:
> 
>> On Mon, 21 May 2007 15:59:48 +0200
>> Panagiotis Issaris <takis.issaris at uhasselt.be> wrote:
>>
>>> Hi,
>>>
>>> Panagiotis Issaris wrote:
>>>> Hi,
>>>>
>>>> Current SVN fails to build when using the following configuration:
>>>>
>>>> ./configure --disable-decoder=h264 --disable-decoder=sonic
>>>> --disable-encoder=sonic --disable-decoder=shorten --disable-decoder=svq3
>>>> --disable-encoder=jpegls --disable-decoder=jpegls --disable-decoder=loco
>>>> --disable-decoder=cavs --disable-decoder=ffv1 --disable-decoder=flac
>>>> --disable-encoder=flac
>>>> ...
>>>> make
>>>> ...
>>>> make[1]: Entering directory `/usr/local/src/rw/ffmpeg/vhook'
>>>> make[1]: Nothing to be done for `all'.
>>>> make[1]: Leaving directory `/usr/local/src/rw/ffmpeg/vhook'
>>>> gcc -L"/usr/local/src/rw/ffmpeg"/libavformat
>>>> -L"/usr/local/src/rw/ffmpeg"/libavcodec
>>>> -L"/usr/local/src/rw/ffmpeg"/libavutil -Wl,--warn-common  -rdynamic
>>>> -export-dynamic -Wl,--as-needed
>>>> -Wl,-rpath-link,"/usr/local/src/rw/ffmpeg"/libavcodec
>>>> -Wl,-rpath-link,"/usr/local/src/rw/ffmpeg"/libavformat
>>>> -Wl,-rpath-link,"/usr/local/src/rw/ffmpeg"/libavutil -g -o ffmpeg_g
>>>> ffmpeg.o cmdutils.o -lavformat -lavcodec -lavutil -lm -lz -ldl
>>>> /usr/local/src/rw/ffmpeg/libavcodec/libavcodec.a(allcodecs.o): In
>>>> function `avcodec_register_all':
>>>> /usr/local/src/rw/ffmpeg/libavcodec/allcodecs.c:200: undefined reference
>>>> to `sonic_ls_encoder'
>>>> collect2: ld returned 1 exit status
>>>> make: *** [ffmpeg_g] Error 1
>>>> takis at issaris:/usr/local/src/rw/ffmpeg$
>>>>
>>>> Fix follows in a second...
>>> Attached patch fixes the above mentioned bug.
>>>
>>>  Makefile |    2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>>
>>> The problem was that sonic.c wasn't compiled in, when only Sonic LS was
>>> selected.
>> Patch ok.
> 
> Oh, and obviously SONIC_LS_ENCODER should also depend on golomb.o depending
> on the order you apply your patches.
Yep, thanks.

And the obviously shorter way to trigger the bug was:
./configure --disable-decoder=sonic --disable-encoder=sonic
Just for archival purposes.

With friendly regards,
Takis
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGUagX9kOxLuzz4CkRAl/jAJ43KCrnwnZVPjLYe1oMLGs4NDhYWgCfVZnt
Bfc/1mA0n2S0ilyf4vTXE0U=
=XVyy
-----END PGP SIGNATURE-----