[FFmpeg-devel] [PATCH] Add rtsp options support ( added option)
Benoit Fouet
benoit.fouet
Tue May 22 09:51:52 CEST 2007
Hello,
Michael Niedermayer wrote:
> Hi
>
> On Mon, May 21, 2007 at 05:59:26PM +0200, Thijs Vermeir wrote:
>
>> Hi
>> On Mon, 2007-05-21 at 17:19 +0200, Michael Niedermayer wrote:
>>
>>> Hi
>>>
>>> On Mon, May 21, 2007 at 05:13:35PM +0200, Thijs Vermeir wrote:
>>>
>>>> Hi
>>>>
>>>>> [...]
>>>>>
>>>> Thanks for your review,
>>>> In the patches applied this issues should be solved.
>>>>
>>> [...]
>>>
>>>
>>>> + int length_of_path = option_list++ - path;
>>>> + path[length_of_path] = 0;
>>>>
>>> no this is even more obfuscated
>>> its just a plain and simple
>>> *option_list++ = 0;
>>>
>> Oeps, this shoud be fixed now.
>>
>
> looks ok
>
>
both applied
(btw, patches that can be applied from trunk directory are also better ;) )
Ben
--
Purple Labs S.A.
www.purplelabs.com
More information about the ffmpeg-devel
mailing list