[FFmpeg-devel] [PATCH] MMSH stream selection support for asf demuxer

Björn Axelsson bjorn.axelsson
Fri Nov 2 18:06:46 CET 2007


On Fri, 2007-11-02 at 16:46 +0100, Michael Niedermayer wrote:
> On Fri, Nov 02, 2007 at 10:51:59AM +0000, Bj?rn Axelsson wrote:
> > Allow propagation of stream selection through the ASF demuxer to the
> > MMSH protocol handler.
> > 
> > Requires the mms_protocol_base.diff patch first.
> 
> no, as long as CONFIG_MMSH_PROTOCOL is not defined this definitly
> does not need any other patch

True, though it makes very little sense without the other patch.

> [...]
> > @@ -106,6 +108,14 @@
> >  }
> >  #endif
> >  
> > +#ifdef CONFIG_MMSH_PROTOCOL
> > +static int is_mms(ByteIOContext *pb)
> > +{
> > +    return url_fileno(pb) && url_fileno(pb)->prot &&
> > +         !strcmp(url_fileno(pb)->prot->name, "mmsh");
> > +}
> > +#endif
> > +
> 
> this ifdef is unneeded, remove it please, its the compilers job to remove
> unused static functions

Removed. Updated patch attached.

-- 
Bj?rn Axelsson                    Phone: +46-(0)90-18 98 97
Intinor AB                          Fax: +46-(0)920-757 10
www.intinor.se
Interactive Television & Digital Media Distribution
-------------- next part --------------
A non-text attachment was scrubbed...
Name: asf_stream_selection.diff
Type: text/x-patch
Size: 933 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071102/1ddb0f13/attachment.bin>



More information about the ffmpeg-devel mailing list