[FFmpeg-devel] [PATCH] Musepack SV8 demuxer and decoder

[Diego Biurrun]

On Sat, Nov 03, 2007 at 08:44:27PM +0100, Aurelien Jacobs wrote:
> On Sat, 3 Nov 2007 19:38:17 +0100
> Diego Biurrun <diego at biurrun.de> wrote:
> 
> > On Sat, Nov 03, 2007 at 09:10:50PM +0200, Kostya wrote:
> > > 
> > > --- libavcodec/mpc8.c	(revision 0)
> > > +++ libavcodec/mpc8.c	(revision 0)
> > > @@ -0,0 +1,373 @@
> > > +
> > > +#ifdef CONFIG_MPEGAUDIO_HP
> > > +#define USE_HIGHPRECISION
> > > +#endif
> > 
> > Why do we have both CONFIG_MPEGAUDIO_HP and USE_HIGHPRECISION?
> 
> I had the exact same thought.
> I tried to drop USE_HIGPRECISION and use directly CONFIG_MPEGAUDIO_HP
> into mpegaudio.h.
> Unfortunatly, mpegaudioenc.c (mp2 encoder) don't work with
> high-presicion (generate mostly random noise).
> So we can't enable hig-precision directly in mpegaudio.h as long as
> mp2 encoder is not fixed.

Open an issue or at least add a comment in the code so this is not
forgotten...

Diego