[FFmpeg-devel] [PATCH] Correct header parsing for CDATA files

[Jonathan Wilson]

> seperate patch and please check a few more bytes, this is too easily true
> in random data
There are no other bytes that are constant enough in .cdata files to use to 
identify valid ones.
If anyone has any other ideas, please feel free to let me know. (all known 
cdata files have the .cdata extention btw)

> spliting a variable -> seperate patch
It is not possible to split the variable and still keep the current if 
statement. So we end up with 2 patches such that if the first one is 
applied and not the second, the code wont compile.

> tabs are forbidden in svn
My editor must have inserted them by mistake (next time I will check my 
patch for tabs and convert them to spaces)

> and the list of codec_tag <-> codec_id mappings should be exported in
> AVInputFormat.codec_tag and av_codec_get_id() (or another function)
> could then be used to map tag->id
Looking at the code, I dont see codec_tag as being the right thing here, 
codec_tag (and the places that seem to use it and reference it) are based 
on the idea that a codec_tag is a FourCC (i.e. 4 alphanumeric characters 
which can then be converted to upper case).