[FFmpeg-devel] [PATCH] allow to call rm_read_audio_stream_info() with NULL AVFormatcontext

Michael Niedermayer michaelni
Mon Nov 5 18:47:47 CET 2007


On Mon, Nov 05, 2007 at 08:13:30AM -0800, Ronald S. Bultje wrote:
> Hi Michael,
> On 11/5/07, Michael Niedermayer <michaelni at gmx.at> wrote:
> >
> > On Sun, Nov 04, 2007 at 09:31:56PM -0800, Ronald S. Bultje wrote:
> > > On 11/4/07, Michael Niedermayer <michaelni at gmx.at> wrote:
> > the very first question about this is, why is this patch necessary?
> > looking at it again it doesnt look like it would make any difference at
> > all besides skiping metadata, i hardly would call that essential
> For RTSP, the AVFormatContext::priv_data is the rtsp context, not the rm
> context. The RMContext only comes into play in a stream-specific manner
> (AVStream, that is). 

thats all fine, but this mess will not enter svn, see the mms patches which
are floating around, they dont use such hacks, implement RTSP as a
URLProtocol or if you prefer keep it as a demuxer but the rm demuxer must be
a full complete instance no NULL contexts or missing or non working

> Also, the ByteIOContext is not the same, since we don't
> want to read directly off the UDP socket, but rather do the RTP-regular

the problem you have is that you have 1 context but 2 things (call them
demuxers or protocol + demuxer) which access them, solution is not to salt
one with if() conditions to work with the wrong/missing context but to
provide it with a proper context!


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071105/cff5f419/attachment.pgp>

More information about the ffmpeg-devel mailing list