[FFmpeg-devel] [PATCH 3/6] rmdec.c: ff_rm_retrieve_cache()

Michael Niedermayer michaelni
Mon Nov 5 23:56:01 CET 2007


On Mon, Nov 05, 2007 at 10:08:26PM +0100, Benoit Fouet wrote:
> Ronald S. Bultje wrote:
> > Hi,
> >
> > On 11/5/07, Benoit Fouet <benoit.fouet at purplelabs.com> wrote:
> >   
> >> is this intentional ?
> >>
> >>     
> >>> +    pkt->stream_index = st->index;
> >>> -        pkt->stream_index = rm->audio_stream_num;
> >>>
> >>>       
> >
> >
> > They are (always, as in you could assert() it) the same, because st is
> > derived from s->streams[rm->audio_stream_num]. The advantage of this is that
> > we don't need a pointer to the RMContext, and thus not to the
> > AVFormatContext. I can also change it to take an extra AVFormatContext
> > argument and then it would look as before.
> >
> >   
> 
> thanks
> i don't think it's worth an extra argument (but it's not up to me to
> decide ;) )

its ok, but i would prefer if ronald would not "hide" such changes in patches
which split code out, it could have been easily done seperately before the
patch
and it also should be commited seperately

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071105/7b83a389/attachment.pgp>



More information about the ffmpeg-devel mailing list