[FFmpeg-devel] [PATCH] Encode Year ID3v2 tag for mp3 files

[Michael Niedermayer]

Hi

On Wed, Nov 14, 2007 at 12:52:48AM +0000, Patrice Bensoussan wrote:
>
> On 14 Nov 2007, at 00:28, Michael Niedermayer wrote:
>
>>>>
>>>
>>> Indeed, I didn't check the man on this one... I assumed the code for 
>>> track
>>> number was right ;-)
>>> Here is a new patch including the fix for both.
>>
>> thats a misunderstanding, there should be 2 patches, 1 for each issue
>>
>>
>> [...]
>>> -        snprintf(tracktxt, sizeof(tracktxt) - 1, "%d", s->track);
>>> +        snprintf(tracktxt, sizeof(tracktxt), "%d", s->track);
>>> +    if(s->year)
>>> +        snprintf(yeartxt, sizeof(yeartxt), "%d", s->year);
>>
>> these could be vertically aligned like:
>>
>>        snprintf(tracktxt, sizeof(tracktxt), "%d", s->track);
>>    if(s->year)
>>        snprintf( yeartxt, sizeof( yeartxt), "%d", s->year );
>>
>
> ok, here is a new patch (removed the fix for track / aligned code as 
> suggested).

looks ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071114/f2c2bb9a/attachment.pgp>