[FFmpeg-devel] [RFC] scenechange_score in AVCodecContext?

[Michael Niedermayer]

On Wed, Nov 14, 2007 at 11:57:41AM +0100, Stefano Sabatini wrote:
> On date Wednesday 2007-11-14 10:55:21 +0100, Diego Biurrun encoded:
> > On Wed, Nov 14, 2007 at 09:47:10AM +0100, Stefano Sabatini wrote:
> > > On date Tuesday 2007-11-13 17:39:34 +0100, Diego Biurrun encoded:
> > > > On Tue, Nov 13, 2007 at 04:14:22PM +0100, Stefano Sabatini wrote:
> > > > > 
> > > > > --- libavcodec/avcodec.h	(revision 11006)
> > > > > +++ libavcodec/avcodec.h	(working copy)
> > > > > @@ -1671,6 +1671,15 @@
> > > > >  
> > > > >      /**
> > > > > +     * scene change score
> > > > > +     * measure the degree of changement between the current and the
> > > > 
> > > > Capitalize, "changement" is not an English word, just use "change".
> > > 
> > > Fixed.
> > > 
> > > Diego please could you define somewhere (for example in
> > > doc/general.texi:Coding Rules) the style to be used for the
> > > documentation, so that I don't have every time to figure out which is
> > > the correct style to adopt?
> > 
> > Correct English?  I'm not sure what you would want me to write in
> > there..
> 
> I was referring to the Capitalization style (and yes I know I still
> have to improve my English).

http://java.sun.com/j2se/javadoc/writingdoccomments/

yes i know its ugh vomit java ...
but its better than writing a vastly worse style recommandition


[...]
> Field definitions:
> /** 
>  * Represent the shed color.
>  * Values should be choosen between 0 and AV_BIKE_COLORS_NB.
>  * - encoding: unusued
>  * - decoding: Set by libavride.
>  *
>  * @warning An inadequate and not carefully considered choice for this
>  * field will result in a terrible and unexpected crash of the bike
>  * riding process.
>  * @see avbike_color_string()
>  */ 
> int shed_color;
> 
> Note that we are using "Represent" rather than "Represents".

yes i know and this is bad it should be *s i dunno what idiot wrote the
comments without ...
also in above case it should be

/**
 * The shed color.

and no should, but rather
Values must be >= 0 and < AV_BIKE_COLORS_NB

also avoid the between without specifying if its inclusive/exclusive of the
end points

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071114/ccf01303/attachment.pgp>