[FFmpeg-devel] [PATCH] nellymoser: better tag handling

Benjamin Larsson banan
Wed Nov 14 16:26:43 CET 2007


Alex Beregszaszi wrote:
> Hi,
>
> On Wed, 2007-11-14 at 16:22 +0100, Benjamin Larsson wrote:
>   
>> Alex Beregszaszi wrote:
>>     
>>> Hi,
>>>
>>> attached patch introduces a better tag handling. The decode block
>>> function works on 64 byte blocks and does not cares about a sampling
>>> rate variable. So it is an easier way to just feed it with every 64 byte
>>> block we received. 
>>>
>>> Also the code warns if the feeded frame is not a multiple of 64 bytes.
>>>
>>> --
>>> Alex
>>>   
>>>       
>> Hmm, I'm undecided. I don't like the idea of the possibility of the 
>> decoder accepting all buffer sizes%64 as valid.
>>     
>
> Well, I will commit the other two patches then, and leave this to be
> decided later on. OK?
>
> --
> Alex
>   

Ok.

MvH
Benjamin Larsson






More information about the ffmpeg-devel mailing list