[FFmpeg-devel] [PATCH] remove lot of empty close functions

Alex Beregszaszi alex
Wed Nov 14 20:17:47 CET 2007


Hi,

> > Index: libavformat/mp3.c
> > ===================================================================
> > --- libavformat/mp3.c	(revision 11019)
> > +++ libavformat/mp3.c	(working copy)
> > @@ -547,11 +547,6 @@
> >      return ret;
> >  }
> >  
> > -static int mp3_read_close(AVFormatContext *s)
> > -{
> > -    return 0;
> > -}
> > -
> >  #ifdef CONFIG_MUXERS
> >  /* simple formats */
> >  
> > @@ -649,7 +644,7 @@
> >      mp3_read_probe,
> >      mp3_read_header,
> >      mp3_read_packet,
> > -    mp3_read_close,
> > +    NULL,
> >      .flags= AVFMT_GENERIC_INDEX,
> >      .extensions = "mp2,mp3,m2a", /* XXX: use probe */
> >  };
> > Index: libavformat/yuv4mpeg.c
> > ===================================================================
> > --- libavformat/yuv4mpeg.c	(revision 11019)
> > +++ libavformat/yuv4mpeg.c	(working copy)
> > @@ -372,11 +372,6 @@
> >      return 0;
> >  }
> >  
> > -static int yuv4_read_close(AVFormatContext *s)
> > -{
> > -    return 0;
> > -}
> > -
> >  static int yuv4_probe(AVProbeData *pd)
> >  {
> >      /* check file header */
> > @@ -394,7 +389,7 @@
> >      yuv4_probe,
> >      yuv4_read_header,
> >      yuv4_read_packet,
> > -    yuv4_read_close,
> > +    NULL,
> >      .extensions = "y4m"
> >  };
> >  #endif
> 
> Are those two NULL needed?

No, good catch.

--
Alex






More information about the ffmpeg-devel mailing list