[FFmpeg-devel] [RFC] Split libavformat

[Diego Biurrun]

On Tue, Nov 20, 2007 at 11:55:23AM +0100, Luca Abeni wrote:
> 
> thanks for the review. I am quite busy at work right now, but tomorrow
> I'll fix my patches according to it.

Sure, we've been waiting ages for this, another day sounds like
nothing..

> Diego Biurrun wrote:
> [...]
> >> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> >> +++ ffmpeg/libavdevice/Makefile	2007-11-19 19:57:22.061554240 +0100
> >> @@ -0,0 +1,36 @@
> >> +#
> >> +# libavdevice Makefile
> >> +# (c) 2000-2003, 2007 Fabrice Bellard
> >> +#
> > 
> > Fabrice did not write this.
> 
> Yes, I know... This is why I said that I had problems when writing the
> license headers ;-)
> I know that the current build system is mainly by you and Mans, but it
> seems that you assigned the copyright to Fabrice... So I did the same.
> Anyway, I'll fix this (in libavdevice and libavnet). What about something
> like the following:
> (c) 2000-2003 Fabrice Bellard
> (c) 2000-2003, 2007 Diego Biurrun
> (c) 2000-2003, 2007 Mans Rullgard
> 
> I do not know if removing Fabrice's copyright is legal, so I propose to
> keep it.
> I do not know the correct years for your and Mans's copyright... Let me
> know the correct ones

I'd just leave out the copyright lines entirely, not all Makefiles have
copyright headers right now.

> >> +# muxers/demuxers
> >> +OBJS-$(CONFIG_BKTR_DEMUXER)              += bktr.o
> > 
> > Is there a better name than (de)muxers for this?
> 
> I do not know... Whatever people think it's better. Let me know, and
> I'll update the makefile (ugh... Changing "CONFIG_*MUXER in something
> else will require to change configure too... I am scared :)

device?

> >> +NAME=avdevice
> >> +LIBVERSION=$(LAVFVERSION)
> >> +LIBMAJOR=$(LAVFMAJOR)
> > 
> > I think I prefer these lines at the top of the Makefile, but yes, this
> > is inconsistently handled in the other Makefiles.
> 
> If you prefer, I can move them to the top

Yes, I'd prefer.

> >> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> >> +++ ffmpeg/libavdevice/allformats.c	2007-11-19 19:57:22.062554088 +0100
> >> @@ -0,0 +1,57 @@
> >> +/*
> >> + * Register all the grabbing formats 
> >> + * Copyright (c) 2000, 2001, 2002, 2007 Fabrice Bellard
> > 
> > Fabrice did not write this.
> 
> Same as above: I copied from libavformat/allformats.c. I can add other
> people's copyright if needed. Just let me know names and years.
> 
> 
> >> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> >> +++ ffmpeg/libavdevice/avdevice.h	2007-11-19 19:57:22.063553936 +0100
> >> @@ -0,0 +1,33 @@
> >> +/*
> >> + * copyright (c) 2001, 2007 Fabrice Bellard
> > 
> > ditto
> 
> I suspect I wrote it :). But I do not believe this file is copyrightable
> at all... I just copied the header from libavformat (I would have no
> problems assigning the copyright to Fabrice). Anyway, would it be ok to
> just remove the copyright line? (I do not know if it would be legal, but
> I am not a lawyer).

I think you can probably leave it out of this file entirely.

Diego