[FFmpeg-devel] [RFC] Split libavformat

Diego Biurrun diego
Thu Nov 22 01:22:43 CET 2007


On Wed, Nov 21, 2007 at 01:40:21PM +0100, Luca Abeni wrote:
>
> Here are a first part of the patches:
> - isolate_os_support.diff comes before all the other patches. I think it
>   can be applied even if the following patches still need work
> - I updated create_libavgrab.diff according to the review. But I do not
>   know if I got the configure part right... It seems to work, but I am
>   not sure if I did the correct thing.
>
> I did not put any copyright on alldevices.c, because even looking at svn 
> log
> and/or svn annotate on libavformat/allformats.c I cannot understand who the
> copyright holder should be...

I think you can leave it out, the only copyrightable things could be
Aurelien's macros...

> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ ffmpeg/libavdevice/Makefile	2007-11-21 12:53:58.000000000 +0100
> @@ -0,0 +1,31 @@
> +#
> +# libavdevice Makefile
> +#

This is pointless, just leave it out.

> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ ffmpeg/libavdevice/alldevices.c	2007-11-21 12:56:16.000000000 +0100
> @@ -0,0 +1,55 @@
> +/*
> + * Register all the grabbing formats

s/formats/devices/ ?

> +/**
> + * Initialize libavdevice and register all the (de)muxers.

Ummm, you're not registering (de)muxers :)

> +    /* (de)muxers */

ditto

> +    REGISTER_INDEVOUTDEV (AUDIO_BEOS, audio_beos);

Maybe INOUTDEV would sound better.

Diego




More information about the ffmpeg-devel mailing list