[FFmpeg-devel] [RFC] Split libavformat

Michael Niedermayer michaelni
Thu Nov 22 14:52:56 CET 2007


On Thu, Nov 22, 2007 at 02:19:31PM +0100, Diego Biurrun wrote:
> On Thu, Nov 22, 2007 at 12:59:07PM +0100, Michael Niedermayer wrote:
> > On Thu, Nov 22, 2007 at 10:03:20AM +0100, Luca Abeni wrote:
> > > Luca Abeni wrote:
> > >> Diego Biurrun wrote:
> > >> [...]
> > >>>> +    REGISTER_INDEVOUTDEV (AUDIO_BEOS, audio_beos);
> > >>> Maybe INOUTDEV would sound better.
> > >> Ok. configure does not seem to like it; I am investigating the reason
> > >> and I hope to fix this soon.
> > >
> > > ...And this is the new patch. I hope I addressed all the comments.
> > > I even went one step further and changed all the *_muxer and *_demuxer
> > > structure names to *_outdev and *_indev (so the patch is bigger, now).
> > > If this is wrong, I will remove this last change.
> > 
> > renames (which are pure cosmetic changes) must be seperate
> > also i dont see any sense in the renames
> 
> Which renames?  If it is about the format registration I disagree,
> calling the input/output devices (de)muxers is suboptimal.

they ARE (de)muxers, implement them as URLProtocol if you like but
as long as they are demuxers they should be called demuxers

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071122/c518f21a/attachment.pgp>



More information about the ffmpeg-devel mailing list