[FFmpeg-devel] [PATCH] Fix VC-1 MC MMX code

Guillaume POIRIER poirierg
Sun Nov 25 10:49:11 CET 2007


On Nov 25, 2007 12:50 AM, Christophe GISQUET <christophe.gisquet at free.fr> wrote:
> Hi,
> When applying one of many changes on vc1dsp_mmx.c, I forgot to validate
> that the decoding was identical to the C version.

I'm the one who applied the patch. I should I checked it more carefully too.

I did notice the picture corruption yesterday, but didn't have the
time to find the offending commit.

> The attached patch fix the typo, which can be noticed by comparing
> current SVN version and earlier versions of my patches, for instance the
> one attached to the mail here:
> http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2007-November/038175.html
> Now, decoding is bitexact to the C version (tested with the patch from
> the other thread about a chroma function).

Yep, that does fix the problem, and it seems trivially good, so I
applied your patch.


BTW: Michael, I hope it's ok that I apply such trivial patches: I'm
not the maintainer of this code, but since the patches are small and
easy to review for me, that leaves your more time to review the
"harder" patches ;-)

A soldier will fight long and hard for a bit of colored ribbon.
 -- Napoleon Bonaparte

More information about the ffmpeg-devel mailing list