[FFmpeg-devel] [PATCH] Fix redirector implementation

[Michael Niedermayer]

Hi

On Tue, Nov 27, 2007 at 01:18:15PM +0100, Luca Abeni wrote:
> Hi all,
> 
> Luca Abeni wrote:
> > someone noticed that after the libavnet split libavformat will depend on
> > libavnet.
> > So, I investigated the problem, and noticed that it is due to the funny
> > implementation of the "redirect" format. I guessed that I'll have to take
> > care of the "XXX: suppress this hack for redirectors" comment around line
> > 467 of libavformat/utils.c...
> [...]
> 
> Even if we decide not to split libavnet, I believe this patch is useful
> (at least, it fixes an "XXX: " comment)...
> If there is something wrong with it, I am willing to fix it; just let me
> know.

i think:

memleak on close
metadata author, ... wont be passed (also a solution to this should not fail
if more metadata fields get added)

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071127/253ffcca/attachment.pgp>