[FFmpeg-devel] [PATCH] DES en-/decryption

Diego Biurrun diego
Mon Oct 15 10:43:47 CEST 2007


On Sun, Oct 14, 2007 at 11:40:43PM +0200, Michael Niedermayer wrote:
> 
> On Sun, Oct 14, 2007 at 02:05:00PM +0200, Reimar D?ffinger wrote:
> > On Sat, Oct 13, 2007 at 10:15:42PM +0200, Reimar D?ffinger wrote:
> > > some DES implementation is needed for asf decryption support.
> > > This version, compared to the one contained in the previous asf patch,
> > > should be quite a bit faster (not benchmarked though).
> > > If you think this is not optimized well enough to belong in libavutil I
> > > tend to suggest to leave it in libavformat unless someone else is
> > > interested in improving it.
> > > I am interested in hearing your comments either way.
> > [...]
> > 
> > Newer version. I ignored your optimization suggestions for the round key
> > stuff - I extracted it from the main loop, so if performance ever
> > matters it will be trivial to put it into its own function or some
> > similar optimization and it should be nearly irrelevant for performance
> > then.
> > I will add license header and multiple inclusion guards to the .h file
> > if you insist though I find it really stupid for a single line (and I
> i dont care about the license header or inclusion guards, also diego will add
> them anyway, so no need to do that yourself :)

Hehe.  While I certainly don't mind a bit of janitorial work here and
there, I would nevertheless appreciate if people could start forming
good habits.  The license header requirement is in the policy and the
multiple inclusion guards should be...

Diego




More information about the ffmpeg-devel mailing list