[FFmpeg-devel] [PATCH] Make RTP work with IPv6 enabled

[Diego Biurrun]

On Mon, Oct 15, 2007 at 10:08:19PM +0200, Michael Niedermayer wrote:
> On Mon, Oct 15, 2007 at 02:22:26PM -0400, Ronald S. Bultje wrote:
> > 
> > On 10/15/07, Michael Niedermayer <michaelni at gmx.at> wrote:
> > >
> > > > --- libavformat/utils.c       (revision 10736)
> > > > +++ libavformat/utils.c       (working copy)
> > > > @@ -2875,7 +2875,7 @@
> > > >                 char *path, int path_size,
> > > >                 const char *url)
> > > >  {
> > > > -    const char *p, *ls, *at, *col, *brk;
> > > > +    const char *p, *ls, *at, *col, *brk, *q;
> > > >
> > > >      if (port_ptr)               *port_ptr = -1;
> > > >      if (proto_size > 0)         proto[0] = 0;
> > > > @@ -2896,9 +2896,12 @@
> > > >      }
> > > >
> > > >      /* separate path from hostname */
> > > > -    if ((ls = strchr(p, '/')))
> > > > -        av_strlcpy(path, ls, path_size);
> > > > -    else
> > > > +    if ((ls = strchr(p, '/'))) {
> > > > +        if ((q = strchr(ls, '?')))
> > > > +            av_strlcpy(path, ls, FFMIN(path_size, q - ls + 1));
> > > > +        else
> > > > +            av_strlcpy(path, ls, path_size);
> > > > +    } else if (!(ls = strchr(p, '?')))
> > > >          ls = &p[strlen(p)]; // XXX
> > 
> > [..]
> > 
> > > for the rest i would like to hear why exactly that is needed, it would
> > > cut the part after the ? off and not return it at all which seems odd to
> > > me, did our old url_split() behave like that?
> > 
> > Yes.
> 
> well then iam ok with the patch

Ronald, can you provide us with a sensible commit log message?  I
believe the patch will be applied in no time then.

Diego