[FFmpeg-devel] [RFC] move wmv2.c to its own file

Aurelien Jacobs aurel
Mon Oct 29 23:34:59 CET 2007

Diego Biurrun wrote:

> Here's another attempt at $subject that builds upon previous work.  It
> does compile, but it slightly increases the size of libavcodec.a,
> probably because I currently duplicate
> static VLC mb_non_intra_vlc[4];
> static VLC inter_intra_vlc;

This is wrong...
Those vars are initialized in msmpeg4.c. The duplicated ones in wmv2.c
are never initialized !

Another problem is the usage of ff_wmv2_decode_mb in msmpeg4.c.
It shouldn't be used when wmv2 is not compiled in.

I fixed those issues in the attached updated patch.
It may be good enough to be committed.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: wmv2-2.diff
Type: text/x-diff
Size: 18861 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071029/24100e3d/attachment.diff>

More information about the ffmpeg-devel mailing list