[FFmpeg-devel] [PATCH] ac3_probe input buffer overrun

Michael Niedermayer michaelni
Sat Sep 1 01:31:59 CEST 2007


Hi

On Tue, Aug 28, 2007 at 09:38:47AM -0000, Wolfram Gloger wrote:
> Hi,
> 
> I found this with valgrind.
> 
> Regards,
> Wolfram.

> --- trunk/libavformat/raw.c	2007-08-11 17:29:37.000000000 +0200
> +++ ffmpeg-test/libavformat/raw.c	2007-08-28 11:29:48.000000000 +0200
> @@ -416,7 +416,7 @@
>      for(; buf < end; buf++) {
>          buf2 = buf;
>  
> -        for(frames = 0; buf2 < end; frames++) {
> +        for(frames = 0; buf2+7 <= end; frames++) { 
>              if(ff_ac3_parse_header(buf2, &hdr) < 0)
>                  break;
>              buf2 += hdr.frame_size;

ac3 maintainer justin, ping!

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070901/7b2787d8/attachment.pgp>



More information about the ffmpeg-devel mailing list